Errors go to stderr as per POSIX

This commit is contained in:
Alessio Treglia 2019-06-26 10:08:12 +01:00 committed by Alessio Treglia
parent 59bb8be6ad
commit 0da6ddb27b
No known key found for this signature in database
GPG key ID: E8A48AE5311D765A

View file

@ -348,7 +348,7 @@ func (c *Command) UsageFunc() (f func(*Command) error) {
c.mergePersistentFlags() c.mergePersistentFlags()
err := tmpl(c.OutOrStderr(), c.UsageTemplate(), c) err := tmpl(c.OutOrStderr(), c.UsageTemplate(), c)
if err != nil { if err != nil {
c.Println(err) c.PrintErrln(err)
} }
return err return err
} }
@ -374,7 +374,7 @@ func (c *Command) HelpFunc() func(*Command, []string) {
c.mergePersistentFlags() c.mergePersistentFlags()
err := tmpl(c.OutOrStderr(), c.HelpTemplate(), c) err := tmpl(c.OutOrStderr(), c.HelpTemplate(), c)
if err != nil { if err != nil {
c.Println(err) c.PrintErrln(err)
} }
} }
} }
@ -903,8 +903,8 @@ func (c *Command) ExecuteC() (cmd *Command, err error) {
c = cmd c = cmd
} }
if !c.SilenceErrors { if !c.SilenceErrors {
c.Println("Error:", err.Error()) c.PrintErrln("Error:", err.Error())
c.Printf("Run '%v --help' for usage.\n", c.CommandPath()) c.PrintErr(fmt.Sprintf("Run '%v --help' for usage.\n", c.CommandPath()))
} }
return c, err return c, err
} }
@ -934,7 +934,7 @@ func (c *Command) ExecuteC() (cmd *Command, err error) {
// If root command has SilentErrors flagged, // If root command has SilentErrors flagged,
// all subcommands should respect it // all subcommands should respect it
if !cmd.SilenceErrors && !c.SilenceErrors { if !cmd.SilenceErrors && !c.SilenceErrors {
c.Println("Error:", err.Error()) c.PrintErrln("Error:", err.Error())
} }
// If root command has SilentUsage flagged, // If root command has SilentUsage flagged,