From 1f5bfa181bf558edc72a9c6fd65dde9063e9473c Mon Sep 17 00:00:00 2001 From: Ryan Curtin Date: Thu, 16 Dec 2021 17:03:32 -0500 Subject: [PATCH] Code review fixes - seeding random number generator and handling error with setting header --- decryptor/reaper.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/decryptor/reaper.go b/decryptor/reaper.go index 1ec3039b..15085e7c 100644 --- a/decryptor/reaper.go +++ b/decryptor/reaper.go @@ -54,6 +54,10 @@ var vaultRegex = regexp.MustCompile(vaultEncryptStart + "(.*)" + vaultEncryptEnd var letterRunes = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ") +func init() { + rand.Seed(time.Now().UTC().UnixNano()) +} + // NewReaperDecryptor returns a Decryptor implementation that will call out to // the reaper service to decrypt any encrypted arguments. func NewReaperDecryptor(url, signingKey, commandExecutorID string) Decryptor { @@ -96,7 +100,10 @@ func (r *ReaperDecryptor) DecryptArguments(args []string) ([]string, error) { } cl := defaultClientWithRetries() - addJWTHeader(retryReq, r.SigningKey) + err = addJWTHeader(retryReq, r.SigningKey) + if err != nil { + return args, fmt.Errorf("error signing request: %s", err) + } resp, err := cl.Do(retryReq) if err != nil {