Apply code review feedback

The completion should be tested also in a mode that returns the description

Co-authored-by: Marc Khouzam <marc.khouzam@gmail.com>
Signed-off-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>

completions_test.go

@@ -2883,6 +2883,26 @@ func TestFixedCompletionsWithCompletionHelpers(t *testing.T) {
 	}
 	rootCmd.AddCommand(childCmd)
 
+	t.Run("completion with description", func(t *testing.T) {
+		output, err := executeCommand(rootCmd, ShellCompRequestCmd, "child", "a")
+		if err != nil {
+			t.Errorf("Unexpected error: %v", err)
+		}
+
+		expected := strings.Join([]string{
+			"apple",
+			"banana",
+			"orange\torange are orange", // this one has the description as expected with [ShellCompRequestCmd] flag
+			":4",
+			"Completion ended with directive: ShellCompDirectiveNoFileComp", "",
+		}, "\n")
+
+		if output != expected {
+			t.Errorf("expected: %q, got: %q", expected, output)
+		}
+	})
+
+	t.Run("completion with no description", func(t *testing.T) {
 		output, err := executeCommand(rootCmd, ShellCompNoDescRequestCmd, "child", "a")
 		if err != nil {
 			t.Errorf("Unexpected error: %v", err)
@@ -2891,7 +2911,7 @@ func TestFixedCompletionsWithCompletionHelpers(t *testing.T) {
 		expected := strings.Join([]string{
 			"apple",
 			"banana",
-		"orange",
+			"orange", // the description is absent as expected with [ShellCompNoDescRequestCmd] flag
 			":4",
 			"Completion ended with directive: ShellCompDirectiveNoFileComp", "",
 		}, "\n")
@@ -2899,6 +2919,7 @@ func TestFixedCompletionsWithCompletionHelpers(t *testing.T) {
 		if output != expected {
 			t.Errorf("expected: %q, got: %q", expected, output)
 		}
+	})
 }
 
 func TestCompletionForGroupedFlags(t *testing.T) {