glenux-archive/spf13--cobra
1
0
Fork 0
mirror of https://github.com/spf13/cobra synced 2025-05-06 13:27:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add tests to verify persistent pre/post hooks run in order

Browse source
This commit is contained in:
Eric Gravert 2018-07-26 20:55:40 -05:00 • committed by Alexander Trost
parent 5876e5a9de
commit f098247d23
1 changed files with 20 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
command_test.go
View file

@ -1117,9 +1117,15 @@ func TestPersistentHooks(t *testing.T) {
childPersPostArgs string childPersPostArgs string
) )
var (
lastPersPreRunCalled string
lastPersPostRunCalled string
)
parentCmd := &Command{ parentCmd := &Command{
Use: "parent", Use: "parent",
PersistentPreRun: func(_ *Command, args []string) { PersistentPreRun: func(_ *Command, args []string) {
lastPersPreRunCalled = "parentCmd"
parentPersPreArgs = strings.Join(args, " ") parentPersPreArgs = strings.Join(args, " ")
}, },
PreRun: func(_ *Command, args []string) { PreRun: func(_ *Command, args []string) {
@ -1132,6 +1138,7 @@ func TestPersistentHooks(t *testing.T) {
parentPostArgs = strings.Join(args, " ") parentPostArgs = strings.Join(args, " ")
}, },
PersistentPostRun: func(_ *Command, args []string) { PersistentPostRun: func(_ *Command, args []string) {
lastPersPostRunCalled = "parentCmd"
parentPersPostArgs = strings.Join(args, " ") parentPersPostArgs = strings.Join(args, " ")
}, },
} }
@ -1139,6 +1146,7 @@ func TestPersistentHooks(t *testing.T) {
childCmd := &Command{ childCmd := &Command{
Use: "child", Use: "child",
PersistentPreRun: func(_ *Command, args []string) { PersistentPreRun: func(_ *Command, args []string) {
lastPersPreRunCalled = "childCmd"
childPersPreArgs = strings.Join(args, " ") childPersPreArgs = strings.Join(args, " ")
}, },
PreRun: func(_ *Command, args []string) { PreRun: func(_ *Command, args []string) {
@ -1151,6 +1159,7 @@ func TestPersistentHooks(t *testing.T) {
childPostArgs = strings.Join(args, " ") childPostArgs = strings.Join(args, " ")
}, },
PersistentPostRun: func(_ *Command, args []string) { PersistentPostRun: func(_ *Command, args []string) {
lastPersPostRunCalled = "childCmd"
childPersPostArgs = strings.Join(args, " ") childPersPostArgs = strings.Join(args, " ")
}, },
} }
@ -1164,12 +1173,8 @@ func TestPersistentHooks(t *testing.T) {
t.Errorf("Unexpected error: %v", err) t.Errorf("Unexpected error: %v", err)
} }
// TODO: currently PersistenPreRun* defined in parent does not if parentPersPreArgs != "one two" {
// run if the matchin child subcommand has PersistenPreRun. t.Errorf("Expected %q parentPersPreArgs, got %q", "one two", parentPersPreArgs)
// If the behavior changes (https://github.com/spf13/cobra/issues/252)
// this test must be fixed.
if parentPersPreArgs != "" {
t.Errorf("Expected blank parentPersPreArgs, got %q", parentPersPreArgs)
} }
if parentPreArgs != "" { if parentPreArgs != "" {
t.Errorf("Expected blank parentPreArgs, got %q", parentPreArgs) t.Errorf("Expected blank parentPreArgs, got %q", parentPreArgs)
@ -1180,12 +1185,8 @@ func TestPersistentHooks(t *testing.T) {
if parentPostArgs != "" { if parentPostArgs != "" {
t.Errorf("Expected blank parentPostArgs, got %q", parentPostArgs) t.Errorf("Expected blank parentPostArgs, got %q", parentPostArgs)
} }
// TODO: currently PersistenPostRun* defined in parent does not if parentPersPostArgs != "one two" {
// run if the matchin child subcommand has PersistenPostRun. t.Errorf("Expected %q parentPersPostArgs, got %q", "one two", parentPersPostArgs)
// If the behavior changes (https://github.com/spf13/cobra/issues/252)
// this test must be fixed.
if parentPersPostArgs != "" {
t.Errorf("Expected blank parentPersPostArgs, got %q", parentPersPostArgs)
} }
if childPersPreArgs != "one two" { if childPersPreArgs != "one two" {
@ -1203,6 +1204,13 @@ func TestPersistentHooks(t *testing.T) {
if childPersPostArgs != "one two" { if childPersPostArgs != "one two" {
t.Errorf("Expected childPersPostArgs %q, got %q", "one two", childPersPostArgs) t.Errorf("Expected childPersPostArgs %q, got %q", "one two", childPersPostArgs)
} }
if lastPersPreRunCalled != "childCmd" {
t.Errorf("Expected %q PersistentPreRun to be the last called, got %q", "childCmd", lastPersPreRunCalled)
}
if lastPersPostRunCalled != "childCmd" {
t.Errorf("Expected %q PersistentPostRun to be the last called, got %q", "childCmd", lastPersPostRunCalled)
}
} }
// Related to https://github.com/spf13/cobra/issues/521. // Related to https://github.com/spf13/cobra/issues/521.