From f8a3d3e96822e98e4df98d51b4dd9e67095a6e5c Mon Sep 17 00:00:00 2001 From: Devin Howard Date: Fri, 2 Dec 2016 18:03:38 -0500 Subject: [PATCH] rubocop topic.rb --- app/models/topic.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/models/topic.rb b/app/models/topic.rb index d13c0350..256fc604 100644 --- a/app/models/topic.rb +++ b/app/models/topic.rb @@ -128,9 +128,11 @@ class Topic < ApplicationRecord protected def create_metamap? - if link == '' and metacode.name == 'Metamap' - @map = Map.create({ name: name, permission: permission, desc: '', arranged: true, user_id: user_id }) - self.link = Rails.application.routes.url_helpers.map_url(:host => ENV['MAILER_DEFAULT_URL'], :id => @map.id) - end + return unless (link == '') && (metacode.name == 'Metamap') + + @map = Map.create(name: name, permission: permission, desc: '', + arranged: true, user_id: user_id) + self.link = Rails.application.routes.url_helpers + .map_url(host: ENV['MAILER_DEFAULT_URL'], id: @map.id) end end