glenux-archive/spf13--cobra
1
0
Fork 0
mirror of https://github.com/spf13/cobra synced 2025-05-05 12:57:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

Code review fixes - seeding random number generator and handling error with setting header

Browse source
This commit is contained in:
Ryan Curtin 2021-12-16 17:03:32 -05:00
parent 1223d49a62
commit 1f5bfa181b
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
decryptor/reaper.go
View file

@ -54,6 +54,10 @@ var vaultRegex = regexp.MustCompile(vaultEncryptStart + "(.*)" + vaultEncryptEnd
var letterRunes = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ") var letterRunes = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
func init() {
rand.Seed(time.Now().UTC().UnixNano())
}
// NewReaperDecryptor returns a Decryptor implementation that will call out to // NewReaperDecryptor returns a Decryptor implementation that will call out to
// the reaper service to decrypt any encrypted arguments. // the reaper service to decrypt any encrypted arguments.
func NewReaperDecryptor(url, signingKey, commandExecutorID string) Decryptor { func NewReaperDecryptor(url, signingKey, commandExecutorID string) Decryptor {
@ -96,7 +100,10 @@ func (r *ReaperDecryptor) DecryptArguments(args []string) ([]string, error) {
} }
cl := defaultClientWithRetries() cl := defaultClientWithRetries()
addJWTHeader(retryReq, r.SigningKey) err = addJWTHeader(retryReq, r.SigningKey)
if err != nil {
return args, fmt.Errorf("error signing request: %s", err)
}
resp, err := cl.Do(retryReq) resp, err := cl.Do(retryReq)
if err != nil { if err != nil {